popa.bogdanp
2020-6-9 12:18:58
Just to clarify, when you say parameter, you mean the dynamic binding kind, right? I’ve implemented all the other suggestions. The docs should update soon. Thanks again!
samth
2020-6-9 12:20:11
Yes. I was thinking of a parameter and a keyword argument for session-request that defaults to the value of the parameter
samth
2020-6-9 12:21:10
Also, I’m really looking forward to throwing away a bunch of code by using this
popa.bogdanp
2020-6-9 12:22:14
<https://github.com/Bogdanp/racket-sentry/blob/master/sentry-lib/sentry.rkt#L102-L147|So am I!> :smile:
popa.bogdanp
2020-6-9 12:23:48
I’m wondering if it’s worth making the #:data
, #:form
and #:json
keyword arguments mutually-exclusive. Right now, json takes precedence over form which takes precedence over data.
samth
2020-6-9 12:24:32
I think mutually exclusive makes sense