Unfortunately it doesn’t look like GHA supports that kind of test output
Thanks for the reference, I will take a look.
@notjack unsure I understand the comment, you think we shouldn’t speed up the PR tests by not performing a full bootstrap?
As @samth said, we could add a hook for a comment like full-ci if a reviewer wanted to force a full ci on the pr. (Actions allows that - I think…)
We could at least test how much faster it gets. Maybe it doesn’t help that much in which case there’s no point to discuss it further.
it’s definitely worth testing
the best would be to automatically detect when we need it
When would that be?
I assume, if the PR only hits Racket files we don’t need a full bootstrap but might need with changing C code. Is there a more specific rule than this?
Oh wait - actually not
right, that’s what I’m thinking
xform is in racket, in this case we should bootstrap, right/
?
although changes to the expander requires re-building (but that changes a C file)
xform is indeed in Racket (that’s the whole issue) and any changes to that would be like changes to C code
ah - right. so we could say - a C file change requires a bootstrapping CI, otherwise no bootstrapping CI.
More rules could be used like, if only a README changes, then no CI is needed?
yes
I will setup the basic for now but keep these things in mind for later. I prefer small changes and see how it evolves than going all-in on CI optimizations. :wink:
also, small changes are easier to manage when not working on something full-time.
indeed; you’ve already done lots!
let me know when everything that the Azure builds are doing is replicated on GHA. I’ll turn the Azure builds off then.
Once Windows CI is in place, https://github.com/racket/racket/pull/2945 we can do that.
Kids are now in bed. I will grab a pizza quickly and work on that before bed. Be right back.
@samth do you have any idea about this? https://github.com/racket/racket/pull/2945#issuecomment-560172662
No idea. We’ve never had CI for racketcs on Windows so I’ve never worked with it
Thanks. I will take another look at it tomorrow.