samth
2020-8-3 12:34:10

btw, @pocmatos, the intent of that sarif changing code is to set the tool name differently for each of the three workflows, but if you look at the code scanning results on github you can see that it doesn’t work


pocmatos
2020-8-3 12:37:02

Yes - I am looking at it. :slightly_smiling_face: I noticed it doesn’t work, which is why I created this https://github.com/racket/racket/pull/3328#issuecomment-667926872



pocmatos
2020-8-3 16:55:30

pocmatos
2020-8-3 16:55:51

To infinity and beyond… :slightly_smiling_face:


samth
2020-8-3 18:11:15

Yay!


samth
2020-8-3 18:11:40

@pocmatos what had I done wrong?


pocmatos
2020-8-4 04:28:18

@samth nothing special really, the adjust.sh script was not being properly generated, so it was not running. Putting the script in a file sorted that out. I think it was due to the tabs in the yml file became real tabs in the script so the #!/bin/bash line was indented and the script just didn’t run.