sorawee
2020-8-31 17:10:03

@mflatt (and possibly @samth?): here’s a guideline from the contribution guide:

> Build with your changes. Don’t break the Racket build. That means at least checking that raco setup runs and completes without errors. If you added or modified documentation, visually inspect the newly rendered documentation to make sure it reads as intended. Well, each time I did raco setup my laptop becomes overheating really bad for at least 20 mins (and possibly more), making it difficult for me to do other work concurrently.

Would it be possible to relax the guideline a little bit? That is, with all CI infrastructure, let PR-er minimally test that it works, and then let CI do raco setup for us? Will this workflow break anything or generate any noise to people?


samth
2020-8-31 17:14:41

First, it seems like raco setup is using too many resources for you.


samth
2020-8-31 17:15:33

Second, the CI doesn’t run the documentation at the moment.


samth
2020-8-31 17:15:46

Maybe that should change.


samth
2020-8-31 17:17:27

Third, one issue is that changes might break other packages, which isn’t run in CI.


samth
2020-8-31 17:18:21

I agree that a full build can take a long time if you change something fundamental (like you’ve been doing), and it would be nice to make that easier.