sorawee
2022-5-18 10:05:19

@samth I have a fix for this problem. Can submit a PR. The question is, has it ever worked? I don’t see any annotation on GitHub (https://github.com/racket/racket/security)


sorawee
2022-5-18 10:07:42

Also, I’m confused. The content of the SARIF files is in this format:

"artifacts": [ { "length": 206345, "location": { "uri": "file:///__w/racket/racket/racket/src/zuo/zuo.c" }, "mimeType": "text/plain", "roles": [ "resultFile" ] } Does GitHub understand paths that start with __w?


sorawee
2022-5-18 10:36:06

Another question: in the workflow, 3m and CS are built by building CGC first, and then use --enable-racket=/usr/bin/racket. Is it actually worth it compared to building the variants directly right away?


samth
2022-5-18 13:48:13

It does work you just can’t see the results because it’s “security”


samth
2022-5-18 13:48:45

I think it saves a bit of time


sorawee
2022-5-18 15:45:02

Ah, right.


sorawee
2022-5-18 15:46:05

I think the file path I mentioned above is an issue. In my local repo, this is what I see


sorawee
2022-5-18 15:49:23

Looks like file:///__w/racket/racket/ should be stripped away


sorawee
2022-5-18 15:52:13

which is weird because it used to work last year