laurent.orseau
2021-1-10 10:25:07

I’m reorganizing the menus for quickscript-extra and quickscript-competition–2020:

There’s a new Re&factor submenu in the Scripts menu, containing extract/put-function and abstract-variable.

Would it make sense to place the autocompletion and definition signatures in the Re&factor submenu? Or do you have a better name/organization?


spdegabrielle
2021-1-10 11:18:47

Sounds good to me!


laurent.orseau
2021-1-10 14:03:31

Thanks. I kept the definitions out of the Refactor menu for now, it’s not really refactoring.


spdegabrielle
2021-1-10 14:04:23

That’s fair.


spdegabrielle
2021-1-10 14:06:47

Can we have a discussion about including some core quickscripts in quickscript itself ? The benefits far outweigh the cost (kb’s).


laurent.orseau
2021-1-10 14:18:54

We can certainly have a discussion :slightly_smiling_face: I think there’s an issue open about that?


laurent.orseau
2021-1-10 14:28:00

The right way to go would be to create a new package like quickscript-essentials that contains only the essential scripts extracted from quickscript-extra, and then have them validated by the core team (robby in particular) If we do go this way, we should probably start with really just a few scripts.

One important constraint is that in the main distribution we must really enforce backward compatibility. It will be hard to remove a script, or refactor it once it sits there (that’s one reason why I’m hesitant).


robby
2021-1-10 14:30:38

I am also cautious here.


robby
2021-1-10 14:31:17

Maybe a good idea would be to have a menu item in the quickscript menu that offered a dialog listing some packages and documentation on them and offered to install them?


spdegabrielle
2021-1-10 14:31:21

agreed.


robby
2021-1-10 14:31:37

And one could also remove them from that menu maybe.


laurent.orseau
2021-1-10 14:34:09

Adding/removing (well, activating/deactivating) is taken care of by Quickscript already via the library. Installing is the missing bit mostly.


laurent.orseau
2021-1-10 14:34:36

Maybe there could be a link in the Scripts menu to the wiki page that lists the available packages and scripts?



spdegabrielle
2021-1-10 14:43:10

I could one simple script by default it would be ‘open terminal here’.


laurent.orseau
2021-1-10 14:44:40

Re listing and installing quickscript packages: it’s an additional mechanism on top of the package system, which adds redundancy and opportunities for new bugs, which is like to avoid if possible.


spdegabrielle
2021-1-10 14:48:08

how so?



laurent.orseau
2021-1-10 15:27:26

Just links are simple enough, sure. I think Robby was mentioning something more complicated and i thought you were thinking the same


spdegabrielle
2021-1-10 15:30:35

I was thinking a menu item that would list packages with the tag ‘quickscript’ and a tooltip that included the package description, each with a submenu to go to the documentation for that package, or trigger installation of the package.


spdegabrielle
2021-1-10 15:33:03


spdegabrielle
2021-1-10 15:43:24

I’m getting this when I use the shadow button: symbol->string: contract violation expected: symbol? given: '(name . add-menu) context...: /Applications/Racket v7.9/share/pkgs/quickscript/shadow-script.rkt:20:0: shadow-script-proc /Applications/Racket v7.9/share/pkgs/quickscript/shadow-script.rkt:39:0: make-shadow-script /Applications/Racket v7.9/share/pkgs/quickscript/library-gui.rkt:106:4: shadow-selected-file /Applications/Racket v7.9/share/pkgs/gui-lib/mred/private/wx/common/queue.rkt:435:6 /Applications/Racket v7.9/share/pkgs/gui-lib/mred/private/wx/common/queue.rkt:486:32 /Applications/Racket v7.9/share/pkgs/gui-lib/mred/private/wx/common/queue.rkt:634:3 not sure what I did wrong


sorawee
2021-1-10 15:43:46

Well, that’s a bug…


robby
2021-1-10 15:46:49

@laurent.orseau I agree that implementing some big new thing that does what’s already done is a bad idea!


robby
2021-1-10 15:47:33

I was thinking if there was one specific package that had a lot of scripts that that might be something to have a menu item to install but if that’s not the case I think that a menu item with a link to some page where documentation exists is best.


robby
2021-1-10 15:47:40

Probably good to link to docs and not the wiki tho.


robby
2021-1-10 15:47:47

Let the docs do the linking to the wiki


laurent.orseau
2021-1-10 15:49:10

Not on my computer right now, bit that’s very strange. Can you open an issue?


robby
2021-1-10 15:49:15

Here’s some code that links to docs in a way that’s probably what you want: https://github.com/racket/games/blob/e57376f067be51257ed12cdf3e4509a00ffd533d/show-scribbling.rkt#L9


spdegabrielle
2021-1-10 15:49:44

It’t probably just me. I do terrible things to my computer. I’ll log it but fee free to close if oyu cant reproduce.


robby
2021-1-10 15:49:56

Searching for calls in that repo should clarify things I suppose. Or, god forbid, reading the docs :wink:


laurent.orseau
2021-1-10 15:50:25

Thanks!


laurent.orseau
2021-1-10 15:52:31

The docs are clear indeed, thanks ;)