pnwamk
2017-3-28 14:25:23

@samth @stamourv is there a discussion somewhere about this issue: https://github.com/racket/typed-racket/issues/112


samth
2017-3-28 14:26:42

@pnwamk ugh


samth
2017-3-28 14:27:02

we should just relax the type of < (and all the other comparisons) on floats


samth
2017-3-28 14:27:26

we used to distinguish NaN in the types, but that was bad because too many things produce NaN


samth
2017-3-28 14:29:53

although that will probably break things like (if (> x 0.0) (sqrt (* x x)) 1.0)


samth
2017-3-28 14:29:55

sigh


pnwamk
2017-3-28 14:30:27

should the type of sqrt be relaxed then?


samth
2017-3-28 14:30:45

no


samth
2017-3-28 14:30:49

that wouldn’t be sound


stamourv
2017-3-28 14:36:03

Sigh.


stamourv
2017-3-28 14:36:19

Yeah, relaxing the types of comparisons on floats is probably the right call.


samth
2017-3-28 14:42:38

@stamourv which parts of the types need changing? the type of < is pretty big :slightly_smiling_face:


stamourv
2017-3-28 14:47:11

I don’t know off the top of my head. Will look later today. Just about to bike to the office.