carette
2019-1-31 17:52:11

carette
2019-1-31 17:53:25

Before I view the serious response draft, I wrote one to let me say what I really wanted to say. Now that I’ve done that, it will be easier to be polite and restrained. However, there are some ideas in my response that I do hope can be used.


carette
2019-1-31 17:54:28

@ccshan can you please give access to to edit the response google doc?


carette
2019-1-31 19:13:08

@samth Do you have any means, beyond slack, to ping @ccshan? I’m unable to access the google doc, so I can’t participate in drafting the response.


samth
2019-1-31 19:14:51

you should now have access


carette
2019-1-31 19:15:11

:+1:


carette
2019-1-31 19:33:41

I’ve edited a couple of places to be more forceful in our language (without being rude/impolite/snarky).


carette
2019-1-31 19:36:03

The response, up to the first indented paragraph, is excellent. If we’re tight for space, it seems that the sections ‘startup speed’ and ‘Backend optimization benefits’ are overly wordy and could be cut down and still say the same thing.


carette
2019-1-31 19:37:23

But I’m not quite sure how to word-count only part of a document in Google Docs.


samth
2019-1-31 19:45:04

if people are happy with my unindented versions we can cut the indented ones


carette
2019-1-31 19:51:13

I’ve edited the “Startup speed” one so that I am now happy with the unindented versions.


ccshan
2019-1-31 20:28:23

Select it


carette
2019-1-31 20:29:23

I tried, didn’t see a word count. But I’ll try again.


ccshan
2019-1-31 21:08:54

Under the Tools menu


carette
2019-1-31 22:21:09

When do we expect to submit the response? It’s due 10am tomorrow, right?


ccshan
2019-1-31 22:29:32

Yes


ccshan
2019-1-31 22:29:47

I’m just final-editing


carette
2019-1-31 22:30:55

offline? [I’m not seeing live changes to the doc]


carette
2019-1-31 22:31:28

Ah, and now I see changes!


ccshan
2019-1-31 22:33:18

I’m done with final editing. I’m fine with the text above the line without the indented parts. Please review the shaded bits (1 yellow comment + 3 purple highlighting) to make sure they don’t need to be dealt with in the response.


ccshan
2019-1-31 22:34:07

Current word count is 726 - probably fine?


carette
2019-1-31 22:35:52

So we should just delete the indented parts? [or move them to below the table]


ccshan
2019-1-31 22:36:04

That can be done on the way to Markdown


carette
2019-1-31 22:37:19

adding a (such as XXX) after the yellow comment would really help. What’s our favourite?


ccshan
2019-1-31 22:37:32

I don’t know what @samth meant when he wrote that


samth
2019-1-31 22:38:39

That’s about the inability of augur to handle two at a time


ccshan
2019-1-31 22:38:47

Oh ok, let me revise


carette
2019-1-31 22:39:41

I kind of like the first purple comment; but I don’t have a strong feeling about include/exclude from the response.


carette
2019-1-31 22:40:34

2nd purple (Review B minor), I don’t think we really need to address that, given the length we already have.


ccshan
2019-1-31 22:41:07

“or the robust algebraic rewriting we perform”?


carette
2019-1-31 22:41:31

:+1:


carette
2019-1-31 22:42:23

I’ve read the last purple 3 times, and it is too cryptic/indirect for me to understand what it entails.


ccshan
2019-1-31 22:43:09

I mean I wouldn’t call our algebraic rewriting robust, but compared to AugurV2…


ccshan
2019-1-31 22:43:36

The last purple is just my asking y’all, should we give a pointer to the hakaru-benchmark repository?


carette
2019-1-31 22:43:55

It’s a response, not something meant for the paper :sunglasses:


carette
2019-1-31 22:44:41

Definitely didn’t get that! I certainly like that idea. But we should definitely hear @rjnw’s opinion on that.


ccshan
2019-1-31 22:52:36

Also, I always have trouble writing the “we thank all” sentence… The sentence “we thank all the reviewers for their helpful comments” kind of suggests there are un-helpful comments


carette
2019-1-31 23:02:20

I’m completely ok with omitting it.


carette
2019-1-31 23:09:33

Given the reviews and this response, I’m actually willing to be hopeful this time.


ccshan
2019-1-31 23:17:54

Reviewer C should champion this “very nice paper” with only one “small concern” already.


carette
2019-1-31 23:18:25

I agree, I don’t know why Reviewer C is so reluctant.


carette
2019-2-1 01:41:16

So are we waiting on @rjnw on that last purple thing before we submit?


carette
2019-2-1 01:41:29

I’d much rather get it done this evening.


rjnw
2019-2-1 01:42:36

I am fine giving a pointer to the repository


rjnw
2019-2-1 01:45:15

carette
2019-2-1 01:47:37

Point to the repo and let them find it?


rjnw
2019-2-1 01:49:23

We can choose which exact example we want to give. I gave link to the folder containing all of our benchmarks.


samth
2019-2-1 01:58:01

note that we are still blinded


rjnw
2019-2-1 01:59:03

Will a gist work?


samth
2019-2-1 01:59:34

yes, use an anonymous one


rjnw
2019-2-1 02:00:12

So what example should we give?


samth
2019-2-1 02:07:30

can someone remind me what they asked for?


ccshan
2019-2-1 02:20:58

Review A: “Minors: It is not clear how to use the proposed methods. It would be nice to include a code example of how to invoke the proposed methods, similar to examples in https://danehuang.github.io/papers/augurv2.pdf

Review :anguished: “The ideas of the paper are quite straightforward. First, the idea of unproduct only applies to pointwise independent formula. In such cases, it seems that one can directly apply one-dimensional optimizations pointwise in the program syntax level. I do not clearly see the need for such a straightforward detour.”


samth
2019-2-1 02:23:02

Ok, then something like the classic sprinkler model seems like a good example, or something we actually mention in the paper


ccshan
2019-2-1 02:24:36

On a different note, I just re-read Reviewer D saying “the performance gain by 2000 times is mostly due to the combination of the histogram optimization and LICM”, as if the simplification pass has no effect. But actually the simplification pass is what makes it possible to execute the specified algorithms at all, inefficiently or efficiently. I’m going to edit the response to point this out, but first let me confirm with @rjnw, does the first row in Table 2 “No optimizations” mean that simplification was run but nothing else was?


rjnw
2019-2-1 02:25:54

Yes that is correct.


ccshan
2019-2-1 02:26:30

Thanks!


ccshan
2019-2-1 02:28:16

As for which code example to provide, if we don’t need to show off histogram or Gibbs, then maybe LinearRegression?


ccshan
2019-2-1 02:34:09

Please take a look at my new edit, in orange.


carette
2019-2-1 02:36:19

I was going to say “looks good”, but then you started re-editing… and now I can still say “looks good” !


samth
2019-2-1 02:39:56

I like the orange text and am happy with submitting now


ccshan
2019-2-1 02:40:31

No gist


ccshan
2019-2-1 02:40:33

?


carette
2019-2-1 02:45:48

Not sure if @rjnw is listening in if he’s not explicitly pinged…



rjnw
2019-2-1 02:46:39

is there any other good service for making anonymous code snippet


ccshan
2019-2-1 02:46:43

It seems that we can just put verbatim code at the bottom of our response?


samth
2019-2-1 02:46:49

oh annoying


samth
2019-2-1 02:46:59

I would do what @ccshan suggests


carette
2019-2-1 02:47:24

There’s no enforced limit to the response, just guidelines?


ccshan
2019-2-1 02:51:58

I think it’s just guidelines painted in pink. So should I just write “Here’s our code for linear regression” above https://github.com/rjnw/hakaru-benchmarks/blob/master/testcode/hksrc/LinearRegression.hk and maybe also include https://github.com/rjnw/hakaru-benchmarks/blob/master/testcode/hksimp/LinearRegressionSimp.hk ?


samth
2019-2-1 03:08:43

I think just the former


carette
2019-2-1 03:13:24

No opinion from me.


samth
2019-2-1 04:12:28

so who’s submitting?


carette
2019-2-1 04:21:14

I don’t think it matters…


samth
2019-2-1 04:21:26

carette
2019-2-1 04:22:26

That’s not where I was going!


carette
2019-2-1 04:23:05

Well, I need to go to bed, I’ve got an early morning tomorrow. But if it doesn’t get submitted tonight, I can do it around 7:30am.


samth
2019-2-1 04:23:27

I think the deadline is 10am


carette
2019-2-1 04:24:06

It is. But I’ll be offline from 8–11. So if it’s me, that’s when it will be!


ccshan
2019-2-1 06:21:18