samth
2018-10-15 15:20:32

@ben the change you made to the makefile that I merged broke some things — what motivated the change?


ben
2018-10-15 15:47:29

@samth when I first cloned pycket, I couldn’t run any make targets because those un-indented lines would always run and complain about a missing file


ben
2018-10-15 15:48:45

indenting looked like the right fix, but it was a guess


samth
2018-10-15 15:49:18

ok, i see that behavior as well if I don’t have the pycket-c-linklets binary


samth
2018-10-15 15:49:42

but if they’re indented then some other things break (in particular anything that needs to do that check)


samth
2018-10-15 15:50:10

@cadr can you look at some other way to do the test?


cadr
2018-10-15 15:57:34

@samth looking at it now


cadr
2018-10-15 15:57:43

@samth btw cderici@snoopy:/home/cderici/pycketland/pycket$ time r -I racket/base -e 1 1

real 0m0.126s user 0m0.103s sys 0m0.023s cderici@snoopy:/home/cderici/pycketland/pycket$ time p -I racket/base -e 1 1

real 0m15.486s user 0m12.833s sys 0m1.568s cderici@snoopy:/home/cderici/pycketland/pycket$ time p -I racket/base -e 1 -c module-prefetch: (sort.rkt) in: #<path:/home/cderici/racketland/racket/racket/collects/racket/private/> module-prefetch: (syntax/readerr) in: #<path:/home/cderici/racketland/racket/racket/collects/syntax/> 1

real 2m11.468s user 2m10.782s sys 0m0.553s cderici@snoopy:/home/cderici/pycketland/pycket$


cadr
2018-10-15 16:01:23

@samth Makefile seems to be working when I inline the check into individual targets (instead of abstracting it into a target and use it like a function)


github2-x
2018-10-15 16:29:20

github2-x
2018-10-15 20:09:44

github2-x
2018-10-16 03:58:34