
ccshan
2019-4-2 14:33:37
What’s complex?
?

ccshan
2019-4-2 14:34:52
(I’m trying to use #:when
at https://github.com/hakaru-dev/hakaru-rktjit/blob/2b7da41520b6ead2e23feb73b12288f39d682359/pass/simplifications.rkt#L109)

rjnw
2019-4-2 14:39:45
it is supposed to be is-complex?
but it is currently racket’s complex?
which is a mistake.

ccshan
2019-4-2 14:40:48
But is-complex? always returns #t on expr-if, so should this rewrite always fire or never fire?

ccshan
2019-4-2 14:41:43
(i.e., should the complex? be removed altogether, or replaced by is-complex?)

ccshan
2019-4-2 14:42:19
To preserve benchmark validity, I propose removing the complex? test altogether (i.e., the rewrite always fires as long as the length is less than 5)

rjnw
2019-4-2 14:43:29
yes I will do that

rjnw
2019-4-2 14:44:45
I will just remove the whole if the match expression itself is enough for that case

ccshan
2019-4-2 14:45:22
Great